2
Vote

Major Bug in Login Case?

description

case "login":
                if (string.IsNullOrEmpty(context.Request.QueryString["ReturnUrl"])) {
                    redirectUrl = liveLogin + context.Request.QueryString["ReturnUrl"];
                }
                else {
                    redirectUrl = liveLogin + context.Request.UrlReferrer;
                }
                break;
 
 
Don't you have your IF/Else Backwards? If the ReturnURL is empty, you append the ReturnURL

comments

KeirGordon wrote Aug 4, 2009 at 6:46 PM

I believe it's not actually possible for your code to work (or to have ever worked) with this problem. The login will always work incorrectly. Not a huge deal, as I fix it and recompile, but not sure how anyone could use the WSP you have available? Thanks for all your work on this great project!

wictor wrote Aug 5, 2009 at 7:08 AM

Yup, its a known bug in the current checkin. It's fixed and will be available in the upcoming release.

KeirGordon wrote Aug 5, 2009 at 5:48 PM

Awesome!

wrote Feb 13, 2013 at 11:05 PM